-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Merge plonk into dev #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Guibas <jtguibas@gmail.com> Co-authored-by: Tamir Hemo <tamir@succinct.xyz> Co-authored-by: Ubuntu <ubuntu@ip-172-31-74-90.ec2.internal> Co-authored-by: Tarik Moon <tarik@tarikmoon.com> Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com> Co-authored-by: Eugene Rabinovich <eugene@succinct.xyz> Co-authored-by: Chris Tian <chris@succinct.xyz> chore: pk/vk serde/clone (#770) chore: SP1ProvingKey serde (#772) chore(recursion): convert ext2felt to hint (#771) chore(recursion): heap ptr checks (#775) feat: groth16 feature flag (#782) chore(recursion): explicitly don't allow witness and public values related apis in sub-builder (#744) fix(recursion): assert curve bit length in circuit p2_hash (#736) fix(recursion): num2bits fixes (#732) chore(recursion): document IR (#737) chore: logup format (#788) chore: merge main into dev (#801) Co-authored-by: Chris T <chris@succinct.xyz> feat: byte multiplicity channel (#800) fix(core): Fix benches warning for unstable features (#763) fix(core): Remove dummy constraint (#783) chore: Clean up TOML files (#796) chore: remove unused deps (#794) Co-authored-by: Bing <b.ing@keemail.me> Co-authored-by: John Guibas <jtguibas@gmail.com> chore: Make some functions const (#774) Co-authored-by: John Guibas <jtguibas@gmail.com> chore: no remainder range checks if division by 0 (#764) Co-authored-by: Tamir Hemo <tamir@succinct.xyz> chore: upgrade checkout action to version with node20 (#734) feat: plonk prover (#795) Co-authored-by: Ubuntu <ubuntu@ip-172-31-78-118.ec2.internal> Co-authored-by: Chris Tian <chris@succinct.xyz> feat: batch sized recursion (#785) Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu> chore: remove unecessary todo chore: get rid of unecessary todo in recursion program fix clippy permutation chore fix clippy hm clippy chore: remove unecessary todos in recursion clippy fixes fix: challenger rate issue fix clippy fix cargo check pin new p3 feat: sp1 core prover opts hm fmt hm fix: install for `verify_plonk_bn254` (#798) feat: update contract artifacts (#802) Co-authored-by: Chris T <chris@succinct.xyz> chore: merge main into dev (#823) fix: update release workflow (#777) feat: release on main (#779) refactor: sdk updates (#784) + make vk/pk serde and Clone feat: switch to ethers (#826) refactor: `prove_plonk` (#827) feat: remove `sp1-zkvm` precompile nightly (#810) fix: update ELF's in tests (#830) docs: simplify quickstart (#819)
- Restore the ability to run the entire process in one chunk by setting `SHARD_BATCH_SIZE` to `0`.
Co-authored-by: John Guibas <jtguibas@gmail.com> Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu> fix: should say feature plonk chore: rename release, set latest release to pre-release encode proof solidity encode proof solidity lint docs chore: remove pr workflow activation on push to dev
update comments prover type lint change to network fix clean feat: enforce only `dev` can merge into `main` (#844) fix: gnark-ffi linking on mac fix: rename remote to network fix book feat: runtime instruction/syscall report (#839) Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu> chore: add network requester to requested proof (#845) feat: execute() exposes ExecutionReport (#847) fix: remove aggregation programs (#849) chore: default reconstruct commitments = true fix: plonk feature off by default (#852) feat: generic const expr (#854) Co-authored-by: Chris Tian <chris@succinct.xyz> doc: recursive program docs (#855) feat: feature flag `alloy_sol_types` (#850) chore: bump plonk artifacts (#864) chore: program doc and remove unnecessary clones (#857) contracts clean fix clean try permalink fix feat: check version for proof requests (#862) feat(sdk): add explorer link (#858)
We use a different set of precompiles and different compilation options
…ules - Renamed the utility function `pad_vec_rows` to `pad_rows` across the entire precompiles library. - Updated all modules in the precompiles library to use the new function name `pad_rows`. - Changes were purely semantic with no alterations to underlying logic or functionality of the code. - Simplified the `pad_vec_rows` function in core/src/utils/mod.rs to incorporate the functionality of `pad_rows` to pad both vectors and nested vectors to a power of two with a minimum size of 8.
Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu> Co-authored-by: Kevin Jue <kjue235@gmail.com> Co-authored-by: Eugene Rabinovich <eugene@succinct.xyz> chore: state_mem validity (#871) chore: constraint selectors when is_real zero (#873) chore: circuit poseidon2 babybear (#870) Co-authored-by: John Guibas <jtguibas@gmail.com> fix: nonce in ed decompress (#874) fix: unit tests to test nonces (#875) chore: increase byte lookup channes (#876) chore: update plonk artifacts (#877)
This commit adds the `nonce` column and respective constraints to all chips that didn't yet have it, as well as other minor misc changes.
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
* feat: Incorporate downloading using AWS cli * chore: SP1 -> Sphinx renaming in Solidity assets * ci: Add S3 credentials (#64) --------- Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
* chore: de-activate G2 precompiles * fix: remove duplicate insertion
…#69) * chore: Add e2e test for checking newly installed Plonk parameters * chore: Use public address of AWS bucket
huitseeker
force-pushed
the
plonk-rebased
branch
from
June 24, 2024 06:33
9d576b6
to
8b7ed48
Compare
huitseeker
added a commit
to lurk-lab/lurk
that referenced
this pull request
Jun 24, 2024
- Replaced standard HashMap with hashbrown's HashMap in `execute.rs` for optimization. - Modified `prove` method in `StarkMachine` to take a new additional argument `opts` of type `SphinxCoreOpts`. - Updated several dependencies branch references in `Cargo.toml` including changing `sphinx-core` to use `plonk-rebased` branch. Companion PR of argumentcomputer/sphinx#72
tchataigner
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are good to go!
wwared
approved these changes
Jun 24, 2024
arthurpaulino
added a commit
to lurk-lab/lurk
that referenced
this pull request
Jun 24, 2024
* chore: Improve and update dependencies - Replaced standard HashMap with hashbrown's HashMap in `execute.rs` for optimization. - Modified `prove` method in `StarkMachine` to take a new additional argument `opts` of type `SphinxCoreOpts`. - Updated several dependencies branch references in `Cargo.toml` including changing `sphinx-core` to use `plonk-rebased` branch. Companion PR of argumentcomputer/sphinx#72 * chore: reset upstream to dev * fmt + fix deprecated call of hybrid_array::Array::clone_from_slice * fix: CARGO_NET_GIT_FETCH_WITH_CLI=true in CI * sphinx requires (exactly) one chip named CPU --------- Co-authored-by: Arthur Paulino <arthurleonardo.ap@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as a rebased alternative to #61.
Immediate follow-ups :
Fixes #38